FCE 756 enable unit test and remove validators #165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kamil-stasiak
force-pushed
the
FCE-756-enable-unit-test-and-remove-validators
branch
from
de078bf
to
260e5a5
Compare
kamil-stasiak
changed the title
kamil-stasiak
force-pushed
the
FCE-756-enable-unit-test-and-remove-validators
branch
from
260e5a5
to
d5d8949
Compare
kamil-stasiak
requested review from
roznawsk,
czerwiukk and
mironiasty
and removed request for
roznawsk and
czerwiukk
czerwiukk
reviewed
Nov 7, 2024
czerwiukk
force-pushed
the
FCE-756-enable-unit-test-and-remove-validators
branch
from
b8b4599
to
044f514
Compare
roznawsk
approved these changes
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
webRTCEndpoint.ts.webRTCEndpoint.ts.rawMetadataandmetadataParsingErrorfields were removed.Motivation and Context
Why were metadata parsers removed from
webRTCEndpoint.ts?Because Fishjam changed the peer metadata structure. Fishjam introduced a separation between peer and server metadata. Previously, if a peer set its metadata to
{ a: "sth" }, Fishjam would broadcast this change to other peers as the same object ({ a: "sth" }). Now, if the user sets the same object, Fishjam broadcasts it as{ peer: { a: "sth" }, server: { b: "other server metadata" } }. I didn't want to introduce more complicated parsers, so I deleted them.Types of changes
Breaking change (fix or feature that would cause existing functionality to not work as expected)